Automation to validate Autoscaling of Nodes on IPI cluster. #125
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prajwal-gawande492 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
the
size/XL
prajwal-gawande492
force-pushed
the
node-autoscaling-ipi
branch
2 times, most recently
from
fb1ae5d to
78d39a1
Compare
| delayAfterAdd: 10m | ||
| delayAfterDelete: 5m | ||
| delayAfterFailure: 30s | ||
| delayAfterFailure: 30s |
There was a problem hiding this comment.
Duplicate Line
| delayAfterFailure: 30s |
There was a problem hiding this comment.
Resolved
|
|
||
| - name: Wait for terminating the busybox pods | ||
| wait_for: | ||
| timeout: 180 |
There was a problem hiding this comment.
Can we use loop until conditions are met (until: with retries and delay) instead of fixed waits.
Look for other places also!
There was a problem hiding this comment.
Added a loop until condition.
| - name: Create a namespace and label it to deploy busybox | ||
| kubernetes.core.k8s: | ||
| name: test | ||
| api_version: v1 | ||
| kind: Namespace | ||
| state: present |
There was a problem hiding this comment.
We can add cleanup for 'test' namespace at the end of the play to avoid leftover resources.
| block: | ||
| - name: Check the machine count before autoscaling | ||
| shell: oc get machineset -n openshift-machine-api -o=jsonpath='{.items[0].status.replicas}' | ||
| register: machine_replicas |
There was a problem hiding this comment.
| register: machine_replicas | |
| register: initial_machine_count |
We can have self-explanatory and clearer variable names
machine_replicas -> initial_machine_count
machines_count -> post_scaleup_machine_count
machineset_replicas -> pre_scaledown_machine_count
There was a problem hiding this comment.
Resolved.
Signed-off-by: prajwal-gawande492 <[email protected]>
prajwal-gawande492
force-pushed
the
node-autoscaling-ipi
branch
from
78d39a1 to
07c9ac6
Compare
|
/lgtm |
3 participants
No description provided.